Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-989 #595

Merged
merged 3 commits into from
Aug 10, 2023
Merged

GEOPY-989 #595

merged 3 commits into from
Aug 10, 2023

Conversation

benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Aug 3, 2023

GEOPY-989 - Remove the forward_ui_json and update labels in write_default_uijson

…on update in geoapps so that they mimic behaviour in Kris's ui.json files (channels checked by default, forward ui.jsons have Survey group and starting model label doesn't have 'Initial'.
Copy link
Contributor

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would mean that we should be able to remove the forward_ui_json in all constants right?

# Conflicts:
#	geoapps/inversion/electricals/direct_current/two_dimensions/constants.py
Copy link
Contributor

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up. Makes ma' brain happy

@domfournier domfournier merged commit 2393367 into develop Aug 10, 2023
8 checks passed
@domfournier domfournier deleted the GEOPY-989 branch August 10, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants