Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-1100 #613

Merged
merged 10 commits into from
Sep 29, 2023
Merged

GEOPY-1100 #613

merged 10 commits into from
Sep 29, 2023

Conversation

domfournier
Copy link
Contributor

@domfournier domfournier commented Sep 26, 2023

GEOPY-1100 - Add triangulation refinement for surfaces

benk-mira
benk-mira previously approved these changes Sep 27, 2023
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a some typing suggestions

geoapps/octree_creation/driver.py Outdated Show resolved Hide resolved
# Conflicts:
#	geoapps/octree_creation/driver.py

Simplify code to rely on surface.extent attribute
Base automatically changed from GEOPY-1059 to release/0.11.0 September 29, 2023 18:52
@domfournier domfournier dismissed benk-mira’s stale review September 29, 2023 18:52

The base branch was changed.

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@domfournier domfournier merged commit 26f143a into release/0.11.0 Sep 29, 2023
7 checks passed
@domfournier domfournier deleted the GEOPY-1100 branch September 29, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants