Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NetworkManagerGUI): prevent potential NRE spam if reference is lost and tidy up #1130

Merged
merged 11 commits into from
Feb 3, 2023
Merged

refactor(NetworkManagerGUI): prevent potential NRE spam if reference is lost and tidy up #1130

merged 11 commits into from
Feb 3, 2023

Commits on Feb 2, 2023

  1. Add autoconfiguration bool option with tooltip

    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    8e8d4a2 View commit details
    Browse the repository at this point in the history

  2. System define and Awake function implementation

    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    adda586 View commit details
    Browse the repository at this point in the history

  3. Short-circuit to prevent NREs 

    Somehow NMGUI can lose references for some reason, so short-circuit to prevent log spam.
    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b9b3a34 View commit details
    Browse the repository at this point in the history

  4. update comment

    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    c06e0d3 View commit details
    Browse the repository at this point in the history

  5. apply Visual Studio IDE0048 recommendation 

    "Add parentheses for clarity"
    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2d90e9f View commit details
    Browse the repository at this point in the history

  6. Regions for tidying up

    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1c6c3cc View commit details
    Browse the repository at this point in the history

  7. Throw warning if trying to Auto Configure but NM field is set 

    If auto configure is set but NetworkManager field is not null, then don't do anything.
    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    bd80bf7 View commit details
    Browse the repository at this point in the history

  8. possible future todo

    @SoftwareGuy
    SoftwareGuy committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    f45f9c8 View commit details
    Browse the repository at this point in the history

  9. Update NetworkManagerGUI.cs 

    Remove regions as per James request
    @SoftwareGuy
    SoftwareGuy authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    fe4b615 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. fix ups as suggested by James' review

    @SoftwareGuy
    SoftwareGuy committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    dbce965 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'MirageNet:master' into fixup-nmgui

    @SoftwareGuy
    SoftwareGuy authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5394254 View commit details
    Browse the repository at this point in the history