Csharp source generator #1144
Closed
Csharp source generator #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Syncvar would only be set from within the same DLL because the list of getter and setters are only checked within the dll With this change we store the name of get/set in the attribute, so we can check that attribute from any dll we process. Also an internal change, instead of properties. weaver now generate methods. It will generate GetNetwork__ only for wrapper syncvars and SetNetwork__ for all syncvars
source generator works with unity 2021+. they are required to add code to dll before weaver runs. If another dll needs a function from the first one, then source generates needs to generate it, because Unity's ILPP does not run in order. BREAKING CHANGE: replacing parts of weaver with source generator
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.