Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: resetting Id on stop server #717

Merged
merged 1 commit into from
Mar 24, 2021
Merged

refactor: resetting Id on stop server #717

merged 1 commit into from
Mar 24, 2021

Conversation

James-Frowen
Copy link
Member

keep ids small if server is stoped and started

@James-Frowen James-Frowen changed the title refacctor: resetting Id on StopServer refacctor: resetting Id on stop server Mar 22, 2021
@James-Frowen James-Frowen changed the title refacctor: resetting Id on stop server refactor: resetting Id on stop server Mar 22, 2021
@James-Frowen
refactor: resetting Id on stop server
af42112 
keep ids small if server is stoped and started
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@James-Frowen James-Frowen merged commit 5be7c6a into master Mar 24, 2021
@James-Frowen James-Frowen deleted the reset-id branch March 24, 2021 20:08
@github-actions
Copy link
Contributor

🎉 This PR is included in version 83.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

James-Frowen added a commit that referenced this pull request Mar 26, 2021
@James-Frowen
Message broker
38312aa 
Squashed commit of the following:

commit f4482f0
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Thu Mar 25 18:13:10 2021 +0000

    fixing compile errors

commit 3671187
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Thu Mar 18 23:52:02 2021 +0000

    using field instead of new references to server/client

commit 087fa7c
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Thu Mar 18 17:13:45 2021 +0000

    fixing use of arg

commit f613f07
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Thu Mar 18 17:04:15 2021 +0000

    fixing handler snot being called

commit f2ecca2
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Thu Mar 18 16:21:00 2021 +0000

    fixing weaver not registering messages

commit 9bfee51
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 16:12:32 2021 +0000

    using interface

commit 03aba30
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 16:12:18 2021 +0000

    marking player as sealed

commit ff750b3
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 14:34:05 2021 +0000

    fixing hostmode

commit a80c56a
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 14:34:01 2021 +0000

    adding test to check setup passes

commit e8f9675
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 14:16:20 2021 +0000

    fixing compile errors in editor tests

commit 0e97990
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 14:08:27 2021 +0000

    fixing compile errors in weaver

commit 1f933a6
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 14:08:12 2021 +0000

    fixing compile errrors in examples

commit 4fc79de
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 14:06:39 2021 +0000

    fixing compile errors in tests

commit 6e4e9da
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 13:56:33 2021 +0000

    adding use of message broke to authenticator

commit d94df03
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:46:05 2021 +0000

    fixing setup

commit 133fe5c
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:37:21 2021 +0000

    renaming test file

commit 75993f7
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:36:47 2021 +0000

    converting NetworkConnection to MessageBroker tests

commit 2b72d81
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:36:16 2021 +0000

    adding Substitute for message handler to test connections

commit 2346172
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:25:53 2021 +0000

    using message handler instead of player

commit b82addc
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:24:46 2021 +0000

    fixing property name

commit 6ffafcb
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:23:45 2021 +0000

    adding MessageHandler to NetworkClient and NetworkServer

commit e6a067b
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 02:11:10 2021 +0000

    adding send passthrough methods to player

commit 5b9094c
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Wed Mar 17 01:54:37 2021 +0000

    fixing compile errors in MessageBroker

    moving MessageBroker to its own file

commit 00dd029
Author: James Frowen <jamesfrowendev@gmail.com>
Date:   Tue Mar 16 18:07:04 2021 +0000

    refactor: moving message sendinng handler to new class

    BREAKING CHANGE: todo

commit 2bccd16
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Wed Mar 24 21:36:44 2021 +0000

    chore(release): 84.0.0 [skip ci]

    * using interface instead of network server ([#722](#722)) ([7312bd8](7312bd8))

    * fields and parameters using NetworkServer are now using INetworkServer Instead

commit 7312bd8
Author: James Frowen <jamesfrowen5@gmail.com>
Date:   Wed Mar 24 21:24:04 2021 +0000

    refactor: using interface instead of network server (#722)

    BREAKING CHANGE: fields and parameters using NetworkServer are now using INetworkServer Instead

commit 4ff53ec
Author: semantic-release-bot <semantic-release-bot@martynus.net>
Date:   Wed Mar 24 21:21:02 2021 +0000

    chore(release): 83.0.0 [skip ci]

    * using interface instead of network client ([#721](#721)) ([703596a](703596a))

    * fields and parameters using NetworkClient are now using INetworkClient Instead

commit 703596a
Author: James Frowen <jamesfrowen5@gmail.com>
Date:   Wed Mar 24 21:06:14 2021 +0000

    refactor: using interface instead of network client (#721)

    BREAKING CHANGE: fields and parameters using NetworkClient are now using INetworkClient Instead

commit 5be7c6a
Author: James Frowen <jamesfrowen5@gmail.com>
Date:   Wed Mar 24 20:08:04 2021 +0000

    refactor: resetting Id on stop server (#717)

    keep ids small if server is stoped and started

commit 913c423
Author: James Frowen <jamesfrowen5@gmail.com>
Date:   Wed Mar 24 20:06:57 2021 +0000

    refactor: adding checked to GetNextNetworkId (#716)

    if id wraps it will cause problems. max value should never be reached but throw incase it does rather than warpping silently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@James-Frowen