Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DONT SQUASH) fix: adding method to remove character without destroying the object #978

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

James-Frowen
Copy link
Member

fixes: #883

BREAKING CHANGE: RemovePlayerForConnection removed, use RemoveCharacter or DestroyCharacter instead

@James-Frowen James-Frowen changed the title fix: adding method to remove character without destroying the object (DONT SQUASH) fix: adding method to remove character without destroying the object Nov 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

fixes: #883

BREAKING CHANGE: RemovePlayerForConnection removed, use RemoveCharacter or DestroyCharacter instead. Note for RemoveCharacter destroyServerObject now defaults to true
@James-Frowen James-Frowen merged commit 528f66b into master Nov 1, 2021
@James-Frowen James-Frowen deleted the remove-charater branch November 1, 2021 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

🎉 This PR is included in version 110.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to remove character from player without destroying it
1 participant