Add VirtletRootVolumeSize annotation #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 20, 2018 14:20
0.3.5 has bad growroot that doesn't really work when we enlarge the libvirt volume
jellonek
reviewed
Aug 20, 2018
There was a problem hiding this comment.
Everything looks perfect, but could you also add an example annotation to one .yamls in examples/?
Maybe also that could be noted somewhere in https://github.com/Mirantis/virtlet/blob/master/docs/volumes.md ?
Reviewed 14 of 14 files at r1.
Reviewable status: 0 of 2 LGTMs obtained
added 3 commits
August 20, 2018 14:46
This fixes CirrOS 0.4.0 compatibility.
ivan4th
commented
Aug 20, 2018
jellonek
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale
jellonek
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale
pigmej
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
Reviewed 13 of 14 files at r1, 5 of 6 files at r2, 1 of 1 files at r3.
Reviewable status: 1 of 2 LGTMs obtained, and 1 stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to enlarge the root volume of VM.
This PR also adds an e2e test for
VirtletRootVolumeSize, which requires updating the default CirrOS image to 0.4.0 which has propergrowrootincluded (growrootfrom CirrOS 0.3.5 didn't notice that the block device was larger then specified in the partition table)This change is