Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check image digests #761

Merged
merged 4 commits into from
Sep 7, 2018
Merged

Check image digests #761

merged 4 commits into from
Sep 7, 2018

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Sep 5, 2018 •
edited
Loading

You can now specify image digests for VM images, e.g.

image: virtlet.cloud/cirros@sha256:0615af1caf345e605e27d5419f8d4c6d087b3b41ff4b979aec094ce0399f04ab

This change is Reviewable

  • verify digests in PullImage
  • verify digests during ImageStatus
  • verify digests during ListImages (skip mismatching images)
  • e2e test

Ivan Shvedunov added 2 commits September 5, 2018 11:29
Check image digests
cd0bffd 
You can now specify image digests for VM images, e.g.
```
image: virtlet.cloud/cirros@sha256:0615af1caf345e605e27d5419f8d4c6d087b3b41ff4b979aec094ce0399f04ab
```
Add sha256 digest to the default image used by e2e
2370579
@ivan4th ivan4th changed the title Check image digests [WiP] Check image digests Sep 5, 2018
@ivan4th ivan4th changed the title [WiP] Check image digests Check image digests Sep 5, 2018
pigmej
pigmej approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1.
Reviewable status: 0 of 2 approvals obtained

lukaszo
lukaszo approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@lukaszo lukaszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 approvals obtained

@lukaszo lukaszo merged commit c4e0541 into master Sep 7, 2018
@lukaszo lukaszo deleted the ivan4th/image-digest-check branch September 7, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pigmej pigmej pigmej approved these changes

@lukaszo lukaszo lukaszo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan4th @lukaszo @pigmej