-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistent root filesystem #767
Conversation
d835a5a
to
3eb67ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 45 of 45 files at r1.
Reviewable status: 0 of 2 approvals obtained (waiting on @ivan4th)
pkg/libvirttools/persistentroot_volumesource.go, line 38 at r1 (raw file):
virtletRootfsMagic = 0x263dbe52ba576702 virtletRootfsMetadataVersion = 1 sectorSize = 512
Minor. Will this also work with .iso images as rootfs where block size has 2kb in size?
It's probably not so important, as afair we already lost support for booting from .iso months ago.
pkg/config/config.go, line 108 at r1 (raw file):
// this field duplicates glog's --v, so no option for it, which is signified // by "+" here (it's only for doc) fs.addIntField("logLevel", "+v", "", "Log level to use", logLevelEnv, 6, 0, math.MaxInt32, &c.LogLevel)
It's temporary, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 approvals obtained (waiting on @ivan4th)
pkg/libvirttools/persistentroot_volumesource.go, line 38 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Minor. Will this also work with .iso images as rootfs where block size has 2kb in size?
It's probably not so important, as afair we already lost support for booting from .iso months ago.
For devicemapper it's always 512 according to the docs, and that's what matters here.
pkg/config/config.go, line 108 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
It's temporary, right?
Oops, committed this by accident initially. fixed.
3eb67ea
to
86c7924
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r2.
Reviewable status: 0 of 2 approvals obtained (waiting on @jellonek)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 approvals obtained (waiting on @jellonek)
If volumeDevices has an entry with 'devicePath: /', it's used as a persistent root filesystem for the VM. It gets overwritten again if the image digest changes. See examples/cirros-vm-persistent-rootfs.yaml
86c7924
to
37e2ee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: 1 of 2 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 34 of 45 files at r1, 9 of 11 files at r2, 1 of 1 files at r3.
Reviewable status: 1 of 2 approvals obtained
If volumeDevices has an entry with 'devicePath: /', it's used as a
persistent root filesystem for the VM. It gets overwritten
again if the image digest changes.
See examples/cirros-vm-persistent-rootfs.yaml
This change is