Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent root filesystem #767

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Add persistent root filesystem #767

merged 1 commit into from
Sep 19, 2018

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Sep 19, 2018

If volumeDevices has an entry with 'devicePath: /', it's used as a
persistent root filesystem for the VM. It gets overwritten
again if the image digest changes.
See examples/cirros-vm-persistent-rootfs.yaml


This change is Reviewable

@ivan4th ivan4th force-pushed the ivan4th/persistent-rootfs branch from d835a5a to 3eb67ea Compare September 19, 2018 07:17
Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 45 of 45 files at r1.
Reviewable status: 0 of 2 approvals obtained (waiting on @ivan4th)


pkg/libvirttools/persistentroot_volumesource.go, line 38 at r1 (raw file):

	virtletRootfsMagic           = 0x263dbe52ba576702
	virtletRootfsMetadataVersion = 1
	sectorSize                   = 512

Minor. Will this also work with .iso images as rootfs where block size has 2kb in size?
It's probably not so important, as afair we already lost support for booting from .iso months ago.


pkg/config/config.go, line 108 at r1 (raw file):

	// this field duplicates glog's --v, so no option for it, which is signified
	// by "+" here (it's only for doc)
	fs.addIntField("logLevel", "+v", "", "Log level to use", logLevelEnv, 6, 0, math.MaxInt32, &c.LogLevel)

It's temporary, right?

Copy link
Contributor Author

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 approvals obtained (waiting on @ivan4th)


pkg/libvirttools/persistentroot_volumesource.go, line 38 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Minor. Will this also work with .iso images as rootfs where block size has 2kb in size?
It's probably not so important, as afair we already lost support for booting from .iso months ago.

For devicemapper it's always 512 according to the docs, and that's what matters here.


pkg/config/config.go, line 108 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

It's temporary, right?

Oops, committed this by accident initially. fixed.

@ivan4th ivan4th force-pushed the ivan4th/persistent-rootfs branch from 3eb67ea to 86c7924 Compare September 19, 2018 07:31
Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r2.
Reviewable status: 0 of 2 approvals obtained (waiting on @jellonek)

Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 approvals obtained (waiting on @jellonek)

If volumeDevices has an entry with 'devicePath: /', it's used as a
persistent root filesystem for the VM. It gets overwritten
again if the image digest changes.
See examples/cirros-vm-persistent-rootfs.yaml
@ivan4th ivan4th force-pushed the ivan4th/persistent-rootfs branch from 86c7924 to 37e2ee7 Compare September 19, 2018 07:49
Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: 1 of 2 approvals obtained

Copy link
Contributor

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 34 of 45 files at r1, 9 of 11 files at r2, 1 of 1 files at r3.
Reviewable status: 1 of 2 approvals obtained

@pigmej pigmej merged commit 4d3ad75 into master Sep 19, 2018
@pigmej pigmej deleted the ivan4th/persistent-rootfs branch September 19, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants