Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for k8s 1.12 #816

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Add support for k8s 1.12 #816

merged 1 commit into from
Dec 8, 2018

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Dec 7, 2018

k8s 1.12 is already mostly supported, but we need to use a newer
version of CRI Proxy to handle new CRI fields like runtimeHandler.

  • ensure temporary CRI proxy version works
  • make a CRI proxy release with 1.12 support
  • update this PR to use the new release of CRI Proxy

This change is Reviewable

k8s 1.12 is already mostly supported, but we need to use a newer
version of CRI Proxy to handle new CRI fields like runtimeHandler.
@ivan4th ivan4th changed the title [WiP] Add support for k8s 1.12 Add support for k8s 1.12 Dec 7, 2018
Copy link
Contributor

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1.
Reviewable status: 0 of 1 approvals obtained

Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@jellonek jellonek merged commit 8edaf19 into master Dec 8, 2018
@jellonek jellonek deleted the ivan4th/k8s-1.12 branch December 8, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants