feat: NetworkTransformHybrid - Hybrid Sync Part 1 #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miwarnec
force-pushed
the
quake_nt2022_fast
branch
from
8580770
to
27feb01
Compare
MrGadget1024
added
work in progress
MrGadget1024
requested changes
Oct 29, 2024
Assets/Mirror/Components/NetworkTransform/NetworkTransformHybrid2022.cs
Outdated
Show resolved
Hide resolved
Assets/Mirror/Components/NetworkTransform/NetworkTransformHybrid2022.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+97
to
+98
| public bool showGizmos; | ||
| public bool showOverlay; |
Comment on lines
79
to
92
| public bool unreliableRedundancy = false; | ||
|
|
||
| [Tooltip("When sending a reliable baseline, should we also send an unreliable delta or rely on the reliable baseline to arrive in a similar time?")] | ||
| public bool baselineIsDelta = true; | ||
|
|
||
| // selective sync ////////////////////////////////////////////////////// | ||
| [Header("Selective Sync & interpolation")] | ||
| public bool syncPosition = true; | ||
| public bool syncRotation = true; | ||
| // public bool syncScale = false; // rarely used. disabled for perf so we can rely on transform.GetPositionAndRotation. | ||
|
|
||
| // BEGIN CUSTOM CHANGE ///////////////////////////////////////////////// | ||
| // TODO rename to avoid double negative | ||
| public bool disableSendingThisToClients = false; |
| // only sync when changed hack ///////////////////////////////////////// | ||
| [Header("Sync Only If Changed")] | ||
| [Tooltip("When true, changes are not sent unless greater than sensitivity values below.")] | ||
| public bool onlySyncOnChange = true; |
miwarnec
force-pushed
the
quake_nt2022_fast
branch
from
27feb01
to
0795681
Compare
MrGadget1024
requested changes
Oct 30, 2024
Assets/Mirror/Components/NetworkTransform/NetworkTransformHybrid2022.cs
Outdated
Show resolved
Hide resolved
Assets/Mirror/Components/NetworkTransform/NetworkTransformHybrid2022.cs
Outdated
Show resolved
Hide resolved
MrGadget1024
requested changes
Oct 30, 2024
Assets/Mirror/Components/NetworkTransform/NetworkTransformHybrid2022.cs
Outdated
Show resolved
Hide resolved
Assets/Mirror/Components/NetworkTransform/NetworkTransformHybrid2022.cs
Outdated
Show resolved
Hide resolved
…id2022.cs Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>
…id2022.cs Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>
…id2022.cs Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>
…id2022.cs Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>
…id2022.cs Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>
…id2022.cs Co-authored-by: MrGadget <9826063+MrGadget1024@users.noreply.github.com>
imerr
reviewed
Nov 2, 2024
imerr
reviewed
Nov 2, 2024
Assets/Mirror/Components/NetworkTransform/NetworkTransformHybrid2022.cs
Outdated
Show resolved
Hide resolved
imerr
reviewed
Nov 2, 2024
Comment on lines
57
to
58
| Vector3 lastDeserializedBaselinePosition = Vector3.zero; | ||
| Quaternion lastDeserializedBaselineRotation = Quaternion.identity; |
There was a problem hiding this comment.
yep, needed for delta compression. gonna put comments on there
miwarnec
force-pushed
the
quake_nt2022_fast
branch
from
6d6d31b
to
6ece0c7
Compare
miwarnec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO DONT MERGE YET:
Changing Mirror from Reliable to (optional) Unreliable takes significant effort.
Let's do this with incremental PRs, each of them tested in a production game.
This PR is step 1: NetworkTransform with Reliable baseline + Unreliable deltas for proper change detection!
Old NetworkTransform
The previous NetworkTransform implements a hacky, 95% correct change detection for Unreliable since bandwidth would be too high otherwise. This PR changes this to a 100% correct change detection - so we'll want this even if we don't go any further!
Benchmarks
Mirror Benchmark:
Same bandwidth, faster server + client perf.