Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OffscreenCanvas undefined #165

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix OffscreenCanvas undefined #165

merged 2 commits into from
Sep 19, 2023

Conversation

u1-liquid
Copy link
Member

What

Fix misskey-dev#11846

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

riku6460
riku6460 reviewed Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@riku6460 riku6460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canvas? に戻すだけで十分な気がする

@u1-liquid
Copy link
Member Author

それがtypescript的に良くないらしいですよ

@u1-liquid u1-liquid force-pushed the fix-offscreencanvas-undefined branch from 9a26a83 to 7c8e920 Compare September 19, 2023 03:19
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@u1-liquid u1-liquid merged commit aaf6257 into MisskeyIO:io Sep 19, 2023
16 checks passed
@u1-liquid u1-liquid deleted the fix-offscreencanvas-undefined branch September 19, 2023 03:50
@noridev noridev mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riku6460 riku6460 riku6460 approved these changes

Assignees
No one assigned
Labels
packages/frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

エラーが発生しサイトにアクセスできない
2 participants
@u1-liquid @riku6460