Hot-fix: Write-back value in memory when it's available in redis #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riku6460
reviewed
Oct 6, 2023
u1-liquid
previously approved these changes
Oct 6, 2023
|
@riku6460 You're true. |
KOBA789
commented
Oct 6, 2023
riku6460
reviewed
Oct 6, 2023
|
resolvedにされてるのみてなかった
|
|
今ハッキリと爆発しているのは CustomEmojiService なので、一旦これ入れて結果を見たいかなという気持ちです。 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
確かに。とりあえずここでは RedisSingleCache のみで良さそうです |
KOBA789
commented
Oct 6, 2023
riku6460
approved these changes
Oct 6, 2023
u1-liquid
approved these changes
Oct 6, 2023
riku6460
added a commit
that referenced
this pull request
Dec 26, 2023
5 tasks
nafu-at
pushed a commit
to TeamNijimiss/nijimiss_legacy
that referenced
this pull request
Jul 17, 2024
…skeyIO#174) * Write-back value in memory when it's available in redis * Fix recursive cache * Fix bug in case that invalid data in redis cache
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Memory 上の lifetime(TTL) は切れたが、Redis 上の lifetime はまだ切れていないという状況で、Redis から読み取った値を MemoryCache に書き戻します。
Why
現状、Redis + MemoryCache の2層キャッシュである RedisSingleCache において、MemoryCache 上の lifetime(TTL) は切れたが、Redis 上の lifetime はまだ切れていないという状況で、都度 Redis へのリクエストと Redis からのレスポンスのパースが走ってしまいます。
（つまり、MemoryCache が仕事をしなくなってしまう）
この影響で、CustomEmojiService ではキャッシュを書いた3分後からの27(=30-3)分間は Redis へのクエリと JSON.parse が大爆発するボーナスタイムになっています。
このパッチはこれを解決します。
Additional info (optional)
Redis 上での残り lifetime を考慮せずに MemoryCache に書き戻してしまうため、実際の lifetime が lifetime + memoryCacheLifetime となります。
たとえば CustomEmojiService では従来30分間の lifetime だったところ、このパッチの影響で33分間キャッシュされることになります。