-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CUE automations #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues with test_automation.py.
Coverage decreased because I deleted a test that wasn't needed anymore since quick actions will no longer be a thing (everything will become a CUE automation, to include manually triggered which is the replacement for quick actions). This part of abodepy init.py in the
I'm not sure if this is even needed anymore since quick actions will be removed. |
Well given that you removed the concept of a generic_type from the automations then you should go ahead and remove it from init.py. :-) Otherwise everything looks good. Since both legacy automations and quick actions are going away anything that references them should be removed from the code. |
Removed the portion of the code mentioned above. Also removed the |
Not sure what I changed caused the coverage to decrease. The stuff being highlighted as changed is in init.py for abodepy in the
Doesn't make any sense to me. This should be triggered based on both test_device.py and test_automation.py. There are test cases where a device or automation id and
Not sure if this was tested in the past but I'm not even sure what this property is used for. I don't see it being called by anything in abodepy. I'm sure it's there for a reason, just can't figure it out.
This is within the Edit: Quick look at my JSON data for the two devices I have classified as "Occupancy" and "device_type.pov" (keypad and multi sensor), both show the "version" field as "0002" and "0001" respectively. I wonder if there's been some changes in how Abode is classifying sensors. Edit 2: After further looking at the |
Abode legacy automations and quick actions are being retired on 28 Feb. This pull request adds support for CUE automations which resolves #41. I've tested this along some Home Assistant changes I've made and so far everything is working as expected. I'm having issues with the
tests_automation_enable
method in test_automation.py, but I'll comment directly in that part of the code in this pull request (it's all commented out currently). I'll definitely have more commits as I continue to test and revise the code but I was hoping to start getting some other eyes on.