Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://unpkg.com/mithril-stream is missing with 404 #2344

Closed
iaddict opened this issue Dec 19, 2018 · 8 comments
Closed

https://unpkg.com/mithril-stream is missing with 404 #2344

iaddict opened this issue Dec 19, 2018 · 8 comments

Comments

@iaddict
Copy link

iaddict commented Dec 19, 2018

Mithril Version: 1.0.0

https://unpkg.com/mithril-stream is not available anymore.

Expected Behavior

unpkg responds with the mithril-stream library.

Current Behavior

When trying to access the stream library at https://unpkg.com/mithril-stream a 404 response is returned.

@fuzetsu
Copy link
Contributor

fuzetsu commented Dec 19, 2018

I'm fairly certain this is an issue with unpkg.com, they are ignoring the main module name in the package.json of the project and redirecting to index.js for all packages.

You can follow the issue here: mjackson/unpkg#156

@fuzetsu
Copy link
Contributor

fuzetsu commented Dec 19, 2018

That said, the mithril-stream npm package may be out of date, hasn't been updated for over a year.
https://www.npmjs.com/package/mithril-stream

The docs recommend using the mithril-stream package:
https://github.com/MithrilJS/mithril.js/blob/next/docs/stream.md#description

So I guess the package should be updated or that recommendation should be changed.

I usually fetch it like this: https://unpkg.com/mithril@next/stream/stream.js

@dead-claudia
Copy link
Member

Closing, since that's unpkg's problem, not ours. (You can always host the script on your own servers - it's pretty easy to do.)

@iaddict
Copy link
Author

iaddict commented Dec 20, 2018

@isiahmeadows Well, maybe at least the documentation should be changed then.
See https://github.com/MithrilJS/mithril.js/blob/master/docs/stream.md

It stopped working yesterday by the way. I now host the file myself.

@dead-claudia
Copy link
Member

@iaddict BTW, it should be working again. But as it stands, unpkg issues aren't generally things we can do anything about on our end, and best practice in general (for any framework or library, not just Mithril) is that if you need guarantees about availability, host it on servers you control rather than relying on a public CDN to host it for you.

@fuzetsu
Copy link
Contributor

fuzetsu commented Dec 20, 2018

@isiahmeadows You may have missed my earlier comment, or misunderstood it or @iaddict 's.
The issue we're discussing is the mithril-stream npm package, it being out of date, and if the docs should continue recommending it if it's not being kept up to date.

That said, the mithril-stream npm package may be out of date, hasn't been updated for over a year.
https://www.npmjs.com/package/mithril-stream
The docs recommend using the mithril-stream package:
https://github.com/MithrilJS/mithril.js/blob/next/docs/stream.md#description

Were you aware of this npm package?

@fuzetsu
Copy link
Contributor

fuzetsu commented Dec 20, 2018

New issue I guess?

@dead-claudia
Copy link
Member

@fuzetsu File a new issue - that hasn't been republished in quite a while. It probably wouldn't be a terrible idea to have those updated as well, but this issue was about unpkg returning erroneous 404s and wrong files (I reproduced their issue with https://unpkg.com/mithril as well), not an outdated bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

No branches or pull requests

3 participants