-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect redirection leading to not found js #156
Comments
Similar problem https://unpkg.com/vue-popperjs |
The same for my https://unpkg.com/vue-custom-context-menu though corresponding part of the |
I have stumbled on the same problem, it seems like the auto resolve that reads package.json is somehow broken |
Yeah, I've observed the same. The issue is somewhere here because it fallback to https://github.com/unpkg/unpkg.com/blob/19b2e5574b5ab5cb711ddbf27c5300d114bed4dc/modules/middleware/fetchPackage.js#L88 But I can't see it on the first sight 😞 |
It seems like unpkg has stopped honoring Currently cache MISSes of base package urls evaluate to /index.js Edit: Here's the har of two calls illustrating the cache behavior I mentioned: https://gist.github.com/davidmsibley/0e6091aae51aa347c68f10a2f957991f |
I haven't traced the line of execution back, but if @jukben is on the right track, it could have something to do with the commit that cleans the package info to cut down on memory usage for the LRU Cache |
attempt to resolve mjackson#156 disclaimer: 🚒 this patch is 100% untested! 🚒
@davidmsibley's hunch seems reasonable to me. i've proposed an (untested) patch in #157. TIL: |
@jgravois thanks for working on that! |
Until the PR is merged and everything is fixed - hopefully - I bypass the problem (on all my codepen documentation examples) by using the tag This is how it looks like: With this form of link the redirection to latest package file works (redirects to https://unpkg.com/splitpanes@1.7.0/dist/splitpanes.umd.min.js) |
Still has problem for https://unpkg.com/http-vue-loader |
I just wanted to chime in and say that every single one of the packages linked to here seems to be working fine for me. This may be fixed already, and just be CloudFlare caching the broken state. Conversely, this could still be broken, and CloudFlare is somehow caching the non-broken state at the edge location nearest to me. Example cURL: https://gist.github.com/AKPWebDesign/f34c8377fabf145d5c2b91e55560157a |
I just clicked that most recent URL, https://unpkg.com/http-vue-loader, and it is 404ing - also with curl But the curl for https://unpkg.com/splitpanes does in fact work for me. Requesting from Los Angeles. I used https://unpkg.com/vue for a semi-production app. :( |
For unpkg.com/mithril, it's returning the wrong file and causing exceptions since |
@danopia, Interestingly it still doesn't work from Australia, does https://unpkg.com/splitpanes resolves to the js file in @1.7.0? |
@antoniandre Try it in a new private/incognito window, so you don't have the browser cache as a variable. |
Hi @mjackson! I am living in France and I have a problem getting this file: https://unpkg.com/preload-it, always returning Cannot find "/index.js" in preload-it@1.2.2. I have tried with mobile 4G and many other browsers without cache enabled... always the same result. Thx for your feedback 😉 |
@mjackson if it's cloudflare still caching, can't you force a purge cache with them? |
I'm still seeing 404s (attempting to load the non-existent /index.js) in Southern California. https://unpkg.com/@esri/arcgis-rest-request |
Problem solved for me in France! 🎉 |
Still 404s here.. |
@jhildenbiddle All those URLs should work now. I manually cleared the cache for them. @xavierfoucrier Just cleared the cache for @jgravois Just cleared the cache for all those URLs as well. They all work for me now. @Sphinxxxx I cleared those URLs one more time from the cache. They all work for me. Looking into a more permanent solution for this that hopefully won't require clearing the entire cache, which would put a huge load on the origin servers. |
Also, as a reminder to everyone this issue is only affecting redirects on bare URLs (i.e. URLs w/out a file path) on some packages for now. If you use full URL paths you shouldn't have any issue. |
OK, I just cleared all responses tagged with |
I can confirm it's fixed here. 👍 |
Looks good! All links I had trouble with work again. |
thanks @mjackson 🙏. a user did report an error in an entirely different library that i am (still) able to reproduce. https://unpkg.com/esri-leaflet-cluster
happy to provide more information if anything else would be useful. |
I still have issues with https://unpkg.com/mithril (requests from denmark) :( |
If it helps to narrow things down: Both of those ( |
and here's an example of another lib of mine that specifies a UMD as the
https://unpkg.com/@esri/arcgis-to-geojson-utils (in Southern California anyway). |
Awesome! Thanks @mjackson - working here now! |
facing same issue with |
it's working now 😂 |
Thanks @mjackson. Very much appreciated. (Hope this didn't ruin your holidays!) |
Same issue for https://unpkg.com/circuit-sdk from some location. |
Hi,
I am getting this issue lately and it did not happen before on my 3 packages,
Accessing the package from this url does not seem to find the package I defined in my package.json >
"unpkg"
value.Let's take splitpanes for instance: hitting https://unpkg.com/splitpanes redirects to the latest available package
splitpanes@1.6.0
, ok.Then does not find the file set in package.json (
"unpkg": "dist/splitpanes.umd.min.js"
) and defaults to index.js that does not exists.Yet, if I hit https://unpkg.com/splitpanes@1.6.0/dist/splitpanes.umd.min.js directly, the file is found.
I have compared with the vue package and it works there while I have the same architecture.
Am I missing something?
Thanks for help!
The text was updated successfully, but these errors were encountered: