Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle [ fragment selector. Fixes #2349 #2352

Merged
merged 3 commits into from
Jan 7, 2019
Merged

Handle [ fragment selector. Fixes #2349 #2352

merged 3 commits into from
Jan 7, 2019

Conversation

vrimar
Copy link
Contributor

@vrimar vrimar commented Dec 29, 2018 •
edited
Loading

Description

Handles [ fragment selector.

Motivation and Context

Fixes 2349.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

dead-claudia
dead-claudia requested changes Dec 30, 2018
View reviewed changes
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod a couple nits.

render/hyperscript.js Outdated Show resolved Hide resolved
render/tests/test-fragment.js Outdated Show resolved Hide resolved
dead-claudia
dead-claudia requested changes Jan 6, 2019
View reviewed changes
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod one last nit.

render/tests/test-fragment.js Show resolved Hide resolved
dead-claudia
dead-claudia approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my previous review. This is fine as-is, and I'll fix the global pollution issue later if necessary.

@dead-claudia dead-claudia merged commit 39c20bd into MithrilJS:next Jan 7, 2019
@snyk-bot snyk-bot mentioned this pull request Feb 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-claudia dead-claudia dead-claudia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Triage/bugs
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

m() should be able to tolerate "[" as a tag and do the right thing about it.
2 participants
@vrimar @dead-claudia