Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing m.censor to API navigation #2843

Merged
merged 1 commit into from
May 20, 2023
Merged

Conversation

dead-claudia
Copy link
Member

Not sure how I forgot about this when I added the method.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

Not sure how I forgot about this when I added the method.
@dead-claudia
Copy link
Member Author

dead-claudia commented May 17, 2023

The referenced page is already live in https://mithril.js.org/censor.html. May be worth also directly editing gh-pages for the current version as well, since it's so minor (and also so critical).

@dead-claudia dead-claudia requested review from a team and removed request for StephanHoyer May 17, 2023 20:24
@tbreuss
Copy link
Contributor

tbreuss commented May 18, 2023

The referenced page is already live in https://mithril.js.org/censor.html. May be worth also directly editing gh-pages for the current version as well, since it's so minor (and also so critical).

Nice! I will add this to my website cleanup branch, too.

@dead-claudia dead-claudia merged commit 3c77beb into next May 20, 2023
@dead-claudia dead-claudia deleted the dead-claudia-patch-1 branch May 20, 2023 10:36
@JAForbes JAForbes mentioned this pull request May 20, 2023
This was referenced Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants