-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Node 20, clean up workflows #2902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dead-claudia
added a commit
to dead-claudia/mithril.js
that referenced
this pull request
Sep 23, 2024
Tests still appear to fail per MithrilJS#2898. Unfortunately, I need actions/runner#2347 to ignore the test failures properly - I need them to be warnings, not hard errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: ignore the commits. It's a mess. Just read the combined diff - the PR itself is the standalone unit. I plan to squash this as I merge anyways.
Description
Update all the build scripts to use Node 20 and clean them up.
I centralized the core setup logic to a single local action, to bring a few benefits:
.github/workflows/test.yml
for the tests and.github/actions/setup/action.yml
for the rest.I also joined all the test workflows into just one workflow and revised the next push to just call it.
And finally, I fixed the
next
push process to condition the prerelease on a successful test run.Motivation and Context
This is unrelated to #2898 and does not address it.
How Has This Been Tested?
It's automation, so the creation of this PR is intended to do the testing.
For the other changes, the worst that could happen is some workflow errors that block (pre-)releases and a workflow failure indicator next to the repo. So in the spirit of Leeroy Jenkins, I say we just go for it.
Types of changes
Checklist:
docs/changelog.md