Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - v2.2.6 #2980

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Release - v2.2.6 #2980

merged 3 commits into from
Oct 1, 2024

Conversation

JAForbes
Copy link
Collaborator

@JAForbes JAForbes commented Sep 26, 2024

Release v2.2.6

Changelog

Patch Changes

m.domFor(): workaround for unintentional mangling. Fix #2842 (@kfule)

Refactoring of domFor() for the internal bundler.

function *domFor1({dom, domSize0}, {generation0} = {}) {
.

Drop Istanbul to kill install warnings (@dead-claudia)

Title's pretty self-explanatory. Also, this isn't really used much in practice. From a local run: ```. $ npm ci.

Signed-off-by: Claudia Meadows <contact@claudiameadows.dev>
@JAForbes JAForbes requested review from a team as code owners September 26, 2024 04:07
@JAForbes
Copy link
Collaborator Author

JAForbes commented Oct 1, 2024

@MithrilJS/admins any objections to pushing thing out to fix #2842 ?

@dead-claudia dead-claudia merged commit dd77cb1 into release Oct 1, 2024
9 checks passed
@dead-claudia
Copy link
Member

@JAForbes There's my list of objections. 😉

@kfule
Copy link
Contributor

kfule commented Oct 4, 2024

@JAForbes @dead-claudia
There seems to be an error in the release workflow and it is not being published to npm.
https://github.com/MithrilJS/mithril.js/actions/runs/11135318559/job/30945104134

@JAForbes
Copy link
Collaborator Author

JAForbes commented Oct 5, 2024

@dead-claudia I think you'll need to take a look

@dead-claudia
Copy link
Member

Sorry, looking at it now. Trying a re-run to see if it resolves itself: https://github.com/MithrilJS/mithril.js/actions/runs/11189351374

@dead-claudia
Copy link
Member

Take 23, using the right branch this time: https://github.com/MithrilJS/mithril.js/actions/runs/11189421869

@dead-claudia
Copy link
Member

Okay, v2.2.8 published. v2.2.6 and v2.2.7 got skipped due to the prior deployment failures. Turns out I needed to add a --force to the git push in that script, but that was it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants