fix round snapshot version check

MixinNetwork · Oct 3, 2022 · 36f8476 · 36f8476
1 parent 2358988
commit 36f8476
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/kernel/round.go b/kernel/round.go
@@ -243,16 +243,22 @@ func ComputeRoundHash(nodeId crypto.Hash, number uint64, snapshots []*common.Sna
 		panic(err)
 	}
 
-	var hash crypto.Hash
 	version := snapshots[0].Version
+	for _, s := range snapshots {
+		if s.Version > version {
+			version = s.Version
+		}
+	}
+
+	var hash crypto.Hash
 	buf := binary.BigEndian.AppendUint64(nodeId[:], number)
 	if version < common.SnapshotVersionCommonEncoding {
 		hash = crypto.NewHash(buf)
 	} else {
 		hash = crypto.Blake3Hash(buf)
 	}
 	for _, s := range snapshots {
-		if s.Version != version {
+		if s.Version > version {
 			panic(nodeId)
 		}
 		if s.Timestamp > end {

diff --git a/storage/badger_validation.go b/storage/badger_validation.go
@@ -142,16 +142,22 @@ func computeRoundHash(nodeId crypto.Hash, number uint64, snapshots []*common.Sna
 		panic(err)
 	}
 
-	var hash crypto.Hash
 	version := snapshots[0].Version
+	for _, s := range snapshots {
+		if s.Version > version {
+			version = s.Version
+		}
+	}
+
+	var hash crypto.Hash
 	buf := binary.BigEndian.AppendUint64(nodeId[:], number)
 	if version < common.SnapshotVersionCommonEncoding {
 		hash = crypto.NewHash(buf)
 	} else {
 		hash = crypto.Blake3Hash(buf)
 	}
 	for _, s := range snapshots {
-		if s.Version != version {
+		if s.Version > version {
 			panic(nodeId)
 		}
 		if s.Timestamp > end {