Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in *.pvtu output #94

Merged
merged 9 commits into from
Jun 8, 2023

Conversation

laetitia-m
Copy link

  1. In inoutcpp_pmmg.c file: Fix bug in snprintf in PMMG_savePvtuMesh and PMMG_savePvtuMesh_and_allData. snprintf cannot support to have input and output filename using the same variable. Use an intermediate filename to overcome this issue.
  2. Fix typo in inoutcpp_pmmg.c file: founded -> found + update regex in accordance in cmake/testing/pmmg_tests.cmake.
  3. For output file at *.pvtu format:
    • In inoutcpp_pmmg.c file: if the output filename has dots "." in the basename, replace them with dashes "-". Why? In VTK function SetFileName(filename), the first dot "." in the filename is interpreted as the extension start. So, whatever the user specifies after the first dot "." will be ignored by VTK. To overcome this, dots are replaced by dashes.
    • In parmmg.c file: a warning is displayed to the user if the basename is changed.
    • In cmake/testing/pmmg_tests.cmake: Add test to check if the basename is well modified in this case.

@Algiane Algiane merged commit 306b3f0 into MmgTools:develop Jun 8, 2023
@Algiane
Copy link
Member

Algiane commented Jun 8, 2023

Thanks

@laetitia-m laetitia-m deleted the feature/fix-citest-pvtu-output branch June 9, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants