Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inoutcpp_pmmg.c
file: Fix bug insnprintf
inPMMG_savePvtuMesh
andPMMG_savePvtuMesh_and_allData
.snprintf
cannot support to have input and output filename using the same variable. Use an intermediate filename to overcome this issue.inoutcpp_pmmg.c
file:founded
->found
+ update regex in accordance incmake/testing/pmmg_tests.cmake
.*.pvtu
format:inoutcpp_pmmg.c
file: if the output filename has dots "." in the basename, replace them with dashes "-". Why? In VTK function SetFileName(filename), the first dot "." in the filename is interpreted as the extension start. So, whatever the user specifies after the first dot "." will be ignored by VTK. To overcome this, dots are replaced by dashes.parmmg.c
file: a warning is displayed to the user if the basename is changed.cmake/testing/pmmg_tests.cmake
: Add test to check if the basename is well modified in this case.