Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Correcting last versions of CMake modules #194

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[CMake] Correcting last versions of CMake modules #194

merged 1 commit into from
Dec 19, 2022

Conversation

loumalouomega
Copy link
Contributor

@loumalouomega loumalouomega commented Dec 19, 2022 •
edited
Loading

@Algiane

  1. Missing else when looking for includes
  2. Wrong CMake argument for REGEX (I think this is depending on the CMake version, correction should work 100% of the times)

@loumalouomega loumalouomega mentioned this pull request Dec 19, 2022
Merged
@Algiane Algiane merged commit adf56d6 into MmgTools:master Dec 19, 2022
@Algiane
Copy link
Member

Algiane commented Dec 19, 2022

Hi @loumalouomega ,

Thanks a lot for these corrections!

Best,
A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Algiane Algiane Algiane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loumalouomega @Algiane