Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Normalize "phenomic(/lib/*)" public API #433

Closed
MoOx opened this issue Apr 28, 2016 · 3 comments · Fixed by #698
Closed

Normalize "phenomic(/lib/*)" public API #433

MoOx opened this issue Apr 28, 2016 · 3 comments · Fixed by #698

Comments

@MoOx
Copy link
Owner

MoOx commented Apr 28, 2016

Currently some stuff are in "phenomic/lib/*" and since #432 we introduced an utility in "phenomic" itself.
When we will rely on webpack 2, it will be safe to make move lib/* interfaces as exported value in "phenomic".
We will have one exception to handle for the loader name that must be a string to a pass, but we can export the string too (eg: import { contentLoader } from "phenomic" and later use a template string in webpack config).
We will have to warn and deprecate all lib/* interfaces (move lib to another place, create a lib that require new files + warn when imported).

@MoOx
Copy link
Owner Author

MoOx commented Sep 1, 2016

I did some stuff about that in #698, but in order to finish this, we will need webpack 2 #421 to be able to serve client and static lib from the same package (otherwise, client build will have everything, and that's too much).

@MoOx MoOx added the blocked label Sep 1, 2016
@MoOx MoOx closed this as completed in #698 Sep 1, 2016
@MoOx MoOx reopened this Sep 1, 2016
@MoOx
Copy link
Owner Author

MoOx commented Sep 1, 2016

This is not finished yet :)

@MoOx MoOx removed the blocked label Sep 15, 2016
@MoOx
Copy link
Owner Author

MoOx commented Sep 15, 2016

Will revisit while doing the monorepo #598

@MoOx MoOx closed this as completed Sep 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant