Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Explode as a monorepo #598

Closed
MoOx opened this issue Aug 4, 2016 · 8 comments · Fixed by #936
Closed

Explode as a monorepo #598

MoOx opened this issue Aug 4, 2016 · 8 comments · Fixed by #936

Comments

@MoOx
Copy link
Owner

MoOx commented Aug 4, 2016

This might require a lot of work but maybe splitting into something like this

phenomic-core
phenomic-content-loader
phenomic-content-loader-plugin-*
phenomic-content-loader-preset-* (bundle of plugins, for example phenomic-content-loader-preset-markdown)
phenomic-static-rendering

Just an idea :)

@MoOx MoOx added the discussion label Aug 4, 2016
@thangngoc89
Copy link
Contributor

What is core and static-rendering ? Still, this is a pretty good ideas and a good chance to clean up and organize the codebase. I hate it when the src folder has too many subfolders

@MoOx
Copy link
Owner Author

MoOx commented Aug 4, 2016

core will be, well the core part (not sure what this will be yet) and static-rendering will be code for the static html generation part. But maybe this should be in the core as well.

spoiler: with monorepo, we might have even more (sub)folders ;)

@thangngoc89
Copy link
Contributor

Biggest trade: no greenkeeper (We are suffering this already with docs and boilerplate)

About the structure, I think we should keep the core of Phenomic in one piece at first. only break plugins section.

@MoOx
Copy link
Owner Author

MoOx commented Aug 26, 2016

There is solution for greekeeper + greenkeeper plans to handle monorepo as well.

@MoOx
Copy link
Owner Author

MoOx commented Nov 29, 2016

@MoOx
Copy link
Owner Author

MoOx commented Dec 2, 2016

@thangngoc89 shared this https://github.com/knitjs/knit looks promising

@bloodyowl
Copy link
Contributor

Going to be fixed with #925

@MoOx MoOx mentioned this issue Jan 12, 2017
Merged
@MoOx MoOx closed this as completed in #936 May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants