Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Evalutate the possibility to make webpack optional #517

Closed
MoOx opened this issue Jun 8, 2016 · 7 comments
Closed

Evalutate the possibility to make webpack optional #517

MoOx opened this issue Jun 8, 2016 · 7 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Jun 8, 2016

Eg: React + inlines styles (+ inline svg as jsx) can works with just babel.
Babel can works without webpack (require hook). So in theory, this can works without webpack. So will make things WAY FASTER. Like A LOT.
You will say "what about .md?". I will say: the loader is pretty simple and stupid, and we can probably extract the logic outside it, and make a simple watcher that update a single JS. The thing is: what about hot loading? We can take a look to "cold loading" https://github.com/chromakode/isolated-core and see if this can works, since we have a store (even if it will become private).

We can allow both method: with webpack, and without.

Thoughts?

@MoOx MoOx added the discussion label Jun 8, 2016
@DavidWells
Copy link
Contributor

Interesting idea.

What about webpack 2. Are there any performance gains to be had there?

The power behind webpack is the large ecosystem of plugins.

If phenomic moves to its own "build" will all custom loaders will need to be rewritten?

Both might be good (or confusing to people) :)

On Jun 8, 2016, at 1:07 PM, Maxime Thirouin notifications@github.com wrote:

Eg: React + inlines styles (+ inline svg as jsx) can works with just babel.
Babel can works without webpack (require hook). So in theory, this can works without webpack. So will make things WAY FASTER. Like A LOT.
You will say "what about .md?". I will say: the loader is pretty simple and stupid, and we can probably extract the logic outside it, and make a simple watcher that update a single JS. The thing is: what about hot loading? We can take a look to "cold loading" https://github.com/chromakode/isolated-core and see if this can works, since we have a store (even if it will become private).

We can allow both method: with webpack, and without.

Thoughts?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@MoOx
Copy link
Owner Author

MoOx commented Jun 9, 2016

No big change with webpack 2.

The api can be: if there is a webpack config file, then build with webpack. If there is none, build without :)
Should not be that confusing.
Like I said, Phenomic custom loader is pretty simple, so no big deal to extract the logic (and keep it as it is) + create a watcher + websocket to send update to files (like webpack dev server does).

@MoOx
Copy link
Owner Author

MoOx commented Jun 9, 2016

The thing I didn't mention is that something like browserify will be at least required.

@thangngoc89
Copy link
Contributor

As you talked about browserify, what about roll up?

@MoOx
Copy link
Owner Author

MoOx commented Jun 9, 2016

why not :)

@bloodyowl
Copy link
Contributor

Going to be fixed with #925

@MoOx MoOx mentioned this issue Jan 12, 2017
Merged
@MoOx
Copy link
Owner Author

MoOx commented May 11, 2017

Fixed in master. v1 might have a browserify example (mostly for fun)

@MoOx MoOx closed this as completed May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants