Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

1.0 #936

Merged
merged 72 commits into from
May 11, 2017
Merged

1.0 #936

merged 72 commits into from
May 11, 2017

Conversation

MoOx
Copy link
Owner

@MoOx MoOx commented Jan 12, 2017

This branch is contains current 0.x AND 1.0 (in packages/*)


If you want to play with alpha version (almost stable architecture architecture - but undocumented yet) you can open NEXT.md and read instructions, it's pretty easy thanks to lerna.

We will iterate here by doing PR on this PR until we are happy. We might eventually push this PR into master sooner and cut a "stable" branch to keep 0.x (for bugfixes only) until this 1.x is out (at least as a beta version).


closes #40
closes #340
closes #358
closes #598
closes #609
closes #630
closes #657
closes #674
closes #713
closes #780
closes #791
closes #806
closes #889
closes #700

This will be closes because not relevant anymore

closes #676
closes #778

Also open the door to #517 #732 #734 #888

@MoOx MoOx added the wip label Jan 12, 2017
@MoOx MoOx mentioned this pull request Jan 12, 2017
lerna-debug.log Outdated
@@ -0,0 +1,52 @@
lerna(verbose) GitUtilities.isInitialized ()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file? Useless diff

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously it's too early to make an actual code review, lot's of stuff are not clean :)
Thanks for reporting.

@MoOx
Copy link
Owner Author

MoOx commented Jan 16, 2017

What do you think about using npm namespace?

@phenomic/core, @phenomic/plugin-react, @phenomic/plugin-*... Will be easier to give npm rights access to anyone (just add to @phenomic). And seems legit. Thoughts?

@MoOx
Copy link
Owner Author

MoOx commented Jan 16, 2017

We could keep "phenomic" for a version with good defaults and no config.

@thangngoc89
Copy link
Contributor

thangngoc89 commented Jan 16, 2017

Yes. Using @phenomic is a very good idea. :D

@MoOx
Copy link
Owner Author

MoOx commented Jan 16, 2017

Seems it's 14$ per month, can't find a free link for oss right now... I won't pay 170$/y for this for an open source project.

@ben-eb
Copy link
Contributor

ben-eb commented Jan 16, 2017

@phenomic/core vs phenomic-core - they're not really that different aside from the price. 😄

@MoOx
Copy link
Owner Author

MoOx commented Jan 16, 2017

The pain with no scope is when a contributor is added, you need to add npm rights for all packages... And when you create a new package, you need to think to add rights to all members etc. That's the main diff imo. Also it looks "official" (and that's another great thing).

@bloodyowl
Copy link
Contributor

@MoOx let's just write a script that reads a OWNERS and runs the command through lerna exec, don't you think? has the advantage of being declarative

@MoOx
Copy link
Owner Author

MoOx commented Jan 18, 2017

Yeah, I think that's what babel does.

<Router history={ browserHistory }>
<Route component={ (props) => <div><Header />{props.children}</div> }>
<Route path="/" component={ Home } />
<Route component={ props => <div>{props.children}</div> }>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bloodyowl can you confirm this wrapper is useless here and for /changelog routes below?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

const lists = await Promise.all([
...post.value.tags.map(tag => req.db.getList(req.params.collection, { limit: limit + 1, lt, reverse }, "tags", tag)),
db.getList(req.params.collection, { limit: limit + 1 }),
])
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bloodyowl can you tell me what lt and reverse are supposed to be/come from?
Also, below I guess it's req.db.getList, not just db.getList? (I am enabling the linter so I am spotting this kind of issue - which allow me to be familiar with the code)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, should be db.

  • lt -> less than
  • reverse -> reverses the query order

they both come from https://github.com/Level/levelup

@vvo
Copy link

vvo commented Jan 20, 2017

I would not go for scoped packages, from recent experience it seems that ultimately not every tooling is ready to read package.json fine with scoped packages (especially yarn)

@ezralalonde
Copy link
Contributor

ezralalonde commented Mar 24, 2017

I have no opinion on whether it's a good idea or not, but it seems that NPM is now offering free namespaces/organizations/scopes to open source. At least cost should no longer be a consideration.

https://medium.com/npm-inc/announcing-free-orgs-48b5f9b39510
https://www.npmjs.com/docs/orgs/

Orgs are free if your organization only has public packages.

@MoOx
Copy link
Owner Author

MoOx commented Mar 24, 2017

I already subscribed for one ;)


function renderToString(store, { renderProps, redirectLocation }, renderHTML) {
const body = ReactDOMServer.renderToString(
<Provider fetch={ fetch } store={ store }>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bloodyowl can you explain me here how this fetch ("spec" fetch) can do his job here when Provider except another kind of fetch (the one that return .json()). I am probably too tired to understand this (I am finishing to add flow types everywhere in the codebase and this is the only issue left for me :) )

linkProperties: {
className: "phenomic-HeadingAnchor",
},
})
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poke @ben-eb :)

>
<a
href="#test"
/>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and poke again @ben-eb

@MoOx
Copy link
Owner Author

MoOx commented May 10, 2017

Hey everyone, you can expect a first alpha at the end of the month! I am sure @revolunet will be happy :D

@revolunet
Copy link
Contributor

haha no pressure guys :) but YES i'm very happy thats a great news thank you 👍

@MoOx
Copy link
Owner Author

MoOx commented May 11, 2017

Bye v0.x, we are going to focus on v1 in master! (tests are broken but no big deal, we will fix this asap)

@MoOx MoOx merged commit 7dffff9 into master May 11, 2017
@MoOx MoOx deleted the next branch May 11, 2017 05:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.