Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Add option to choose your linting eslint shareable config on setup #631

Closed
MoOx opened this issue Aug 17, 2016 · 6 comments
Closed

Add option to choose your linting eslint shareable config on setup #631

MoOx opened this issue Aug 17, 2016 · 6 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Aug 17, 2016

eslint-config-i-am-meticulous is nice, but too probably opininated (according to user feedback). We should ask what user want, and offer another by default (standard? airbnb?...)
We should ensure that eslint autofix can cover some common config so when we switch the config and run autofix the theme does not give any error (that might be a non problem when default boilerplate... theme! will be in its own package - or maybe not, according to the "eject" feature #596).

@thangngoc89
Copy link
Contributor

I dont think eslint autofix is capable of doing such a thing. A test should confirm tht

@MoOx
Copy link
Owner Author

MoOx commented Aug 17, 2016

eslint autofix can adjust indentation, change quote from double to single, add or remove semicolons, add or remove trailing comma, etc. It can handle a lot, more and more each days!

@revolunet
Copy link
Contributor

Personally i disabled autofix because i prefer to have my warnings in my IDE and handle linting progressively. looks like im doing a lot of ⌘+S while coding and this can be annoying.

Linting is too restrictive here for me but everyone as it tastes so i suggest to just make linting non-blocking :)

@MoOx
Copy link
Owner Author

MoOx commented Aug 17, 2016

autofix can be used "once" when user have choose his config, right after config. I will probably remove autofix, or ask in setup. We should find a way to make setup more flexible (but I have no idea atm on how to make this flexible... codemods?)

@revolunet
Copy link
Contributor

CLI flag ?

@MoOx
Copy link
Owner Author

MoOx commented Aug 17, 2016

not sure if cli/options should adjust webpack config loader options (will make more boilerplate). But when we will provide default theme as a package, why not!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants