This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
Optimistic loading (new way to display loading state) #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, if you remove your
PageLoading
layouts, you will automatically receive partial data in the correct (future) layout (only head, body won't be defined untilisLoading
is != true).Should not be a breaking change if you do still use
PageLoading
.If you still use
PageLoading
, you can define a static property in some layouts to tell Phenomic to send anisLoading
props to your specific layout instead of usingPageLoading
for this specific transition.You can refer to the minimal change you can do in the docs code if you want to replace
PageLoading
usage by optimistic loading viaisLoading
props.This probably allows you to handle page transition (ref #587) since current layout won't be unmounted.
Closes #836
Closes #824