Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Optimistic loading (new way to display loading state) #855

Merged
merged 7 commits into from
Nov 2, 2016
Merged

Conversation

MoOx
Copy link
Owner

@MoOx MoOx commented Oct 31, 2016

Now, if you remove your PageLoading layouts, you will automatically receive partial data in the correct (future) layout (only head, body won't be defined until isLoading is != true).

phenomic-optimistic-loading

Should not be a breaking change if you do still use PageLoading.

If you still use PageLoading, you can define a static property in some layouts to tell Phenomic to send an isLoading props to your specific layout instead of using PageLoading for this specific transition.

You can refer to the minimal change you can do in the docs code if you want to replace PageLoading usage by optimistic loading via isLoading props.

This probably allows you to handle page transition (ref #587) since current layout won't be unmounted.

Closes #836
Closes #824

@MoOx
Copy link
Owner Author

MoOx commented Nov 1, 2016

@DavidWells does this looks good to you?

@DavidWells
Copy link
Contributor

DavidWells commented Nov 1, 2016

Looks great! LGTM

@MoOx
Copy link
Owner Author

MoOx commented Nov 2, 2016

Next time feel free to approve the PR via the dedicated github feature :)

@MoOx MoOx merged commit bd86ae9 into master Nov 2, 2016
@MoOx MoOx deleted the new-loading branch November 2, 2016 20:35
@montogeek
Copy link
Contributor

Oh la la!

@DavidWells
Copy link
Contributor

@MoOx Where is that button? =P I've haven't ever had to use that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants