-
Notifications
You must be signed in to change notification settings - Fork 203
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update pull_request_template.md (#590)
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
- Loading branch information
1 parent
35b2832
commit 4f34a8b
Showing
1 changed file
with
24 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,25 @@ | ||
Please see our contributing guidelines (contributing.md) primarily make sure to sign our cla as we cannot accept code externally without a signed cla | ||
Closes # (Issue number) | ||
|
||
https://opensource.dropbox.com/cla/ | ||
## Description | ||
What changes are you introducing with this PR? Please include motivation and context. | ||
|
||
## Type of Change | ||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
- [ ] This change requires a documentation update | ||
|
||
## Test Plan | ||
How has this been tested? Please describe the tests that you added to verify your changes. | ||
|
||
## Checklist: | ||
Before submitting your PR, please review and check all of the following: | ||
- [ ] I have performed a self-review of my own code | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have made corresponding changes to the documentation | ||
- [ ] My changes generate no new warnings | ||
- [ ] I have added tests that prove my change is effective | ||
- [ ] New and existing unit tests pass locally with my changes | ||
|
||
## Additional Notes: | ||
Add any other information about the PR here. |