Update kermit to 2.0.4 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MobileNativeFoundation#653 and MobileNativeFoundation#654 Signed-off-by: Scott Olcott <scottolcott@gmail.com>
solcott
force-pushed
the
kermit_update
branch
from
fae7a59 to
c4482b5
Compare
matt-ramotar
approved these changes
Sep 19, 2024
amrfarid140
pushed a commit
to amrfarid140/Store
that referenced
this pull request
Oct 1, 2024
Fixes MobileNativeFoundation#653 and MobileNativeFoundation#654 Signed-off-by: Scott Olcott <scottolcott@gmail.com> Signed-off-by: Amr Yousef <amr.farid140@gmail.com>
amrfarid140
added a commit
to amrfarid140/Store
that referenced
this pull request
Oct 1, 2024
This reverts commit 76f34d4. Signed-off-by: Amr Yousef <amr.farid140@gmail.com>
matt-ramotar
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Add test case Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Always Release storeLock Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Update kermit to 2.0.4 (#655) Fixes #653 and #654 Signed-off-by: Scott Olcott <scottolcott@gmail.com> Signed-off-by: Amr Yousef <amr.farid140@gmail.com> * Revert "Update kermit to 2.0.4 (#655)" This reverts commit 76f34d4. Signed-off-by: Amr Yousef <amr.farid140@gmail.com> --------- Signed-off-by: Amr Yousef <amr.farid140@gmail.com> Signed-off-by: Scott Olcott <scottolcott@gmail.com> Co-authored-by: Scott Olcott <scottolcott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #653
Closes #654
Description
Update kermit to 2.0.4. When kermit updated to 2.0.0 it changed
CommonWriters default constructor to a new one that had a default parameter. This causes KMP iosApps using Store 5.0.0 and Kermit 2.0.0+ to crash because it can't find the defaultCommonWriterconstructor.Type of Change
Test Plan
No new tests as this is a dependency update. I tested locally in KMP Android/iOS apps
Checklist:
Before submitting your PR, please review and check all of the following:
Additional Notes:
Add any other information about the PR here.