Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document extension functions in store.kt #669

Conversation

blakelee
Copy link
Contributor

@blakelee blakelee commented Nov 7, 2024

Closes #668

Description

This PR adds documentation to store.kt so that it's easier to grok all the different types that there are. Along with calling out needing to handle exceptions otherwise there could be potential crashes that are hard to find within your logging.

Type of Change

  • This change is a documentation update

Checklist:

Before submitting your PR, please review and check all of the following:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@matt-ramotar matt-ramotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Blake Oliveira <blake@blakelee.net>
@blakelee blakelee force-pushed the blakeoliveira/document-extension-functions branch from d9e23ee to 31d9b21 Compare November 8, 2024 07:51
@blakelee
Copy link
Contributor Author

blakelee commented Nov 8, 2024

Fixed the sign off

@matt-ramotar matt-ramotar merged commit 879bf9f into MobileNativeFoundation:main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Fetcher Exceptions Not Being Caught
2 participants