Keep scheme sorting info in rsync #2829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yongjin Cho <49507839+yongjincho92@users.noreply.github.com>
| @@ -134,7 +134,7 @@ rsync \ | |||
| --chmod=u+w,F-x \ | |||
| --exclude=project.xcworkspace \ | |||
| --exclude=rules_xcodeproj/bazel \ | |||
| --exclude=xcuserdata \ | |||
| --exclude="*.xcbkptlist" \ | |||
There was a problem hiding this comment.
User created schemes should be left alone as well. Probably better to leave this exclude as is, and copy over the schememanagement file, similar to the incremental installer?
rules_xcodeproj/xcodeproj/internal/templates/incremental_installer.sh
Lines 138 to 142 in 4f68608
There was a problem hiding this comment.
Sounds good, let me update this PR
There was a problem hiding this comment.
@yongjincho92 Any progress on this?
|
@yongjincho92 This still seems like a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue :
Xcode schemes were not sorted as expected
Cause :
Scheme sorting hint file was included under xcuserdata dir and was not being rsycn due to existing --exaclude pattern.
Change :
Make the existing exclude a little bit more specific.