-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to vehicle_types #470
Conversation
We found it useful to show vehicle-type specific texts to our customers
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Friday, January 20th. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 from Transit, but, pending approval, this should also be a localized array. |
+1 from Entur |
This proposal doesn't seem particularly controversial, but to the point raised by @cmonagle, it does feel like it should be a localized string array, assuming #460 goes through. I'll admit I'm not super familiar with GBFS voting and governance, but would switching that later require another vote? Or do you think this would go in before #460? |
@bdferris-v2 Yes it's been raised already in other channels but you're right. Whichever gets merged first, the other PR needs to be updated. |
Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 from Lime |
+1 from Joyride, though this is not something we would use in the short term |
+1 from PBSC |
+1 from BCycle |
+1 from Ito |
+1 from Superpedestrian. |
+1 looks good to the OMF staff |
This vote has now closed, and it passes! Votes in favor: Note: The changes proposed in #460 will be applied to this change. |
We found it useful at nextbike to show vehicle-type specific texts to our customers.
https://github.com/MobilityData/gbfs/wiki/Extensions-outside-of-the-specification
Is this a breaking change?
Which files are affected by this change?
vehicle_types.json