Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript / Deno support #81

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

taisukef
Copy link

@taisukef taisukef commented May 3, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 3, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @taisukef. Some comments in-line.

console.log(feed);
console.log(feed.entity[0].vehicle);

// todo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests?

console.log(feed);
console.log(feed.entity[0].vehicle);

// todo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests?


## Regenerate the language binding source from gtfs-realtime.proto.

1. make nodejs/gtfs-realtime.js and edit as ES module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the overhead of maintaining bindings in multiple languages, we've been shying away from adopting any new languages where the update process can't be automated. It looks like this updating process requires hand-editing to update the bindings? More details here are needed.

@maximearmstrong would need to weigh in on MobilityData's willingness to take on the additional responsibility of manually updating these bindings going forward.

Related - we should update the "Other languages" section of the README to more specifically itemize the requirements for new binding language contributions (e.g., supported by official PB tooling, process to update and publish release can be automated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants