Merge 6925d4a into cc78161

MobilityData · Jun 29, 2022 · 3b66a00 · 3b66a00
2 parents cc78161 + 6925d4a
commit 3b66a00
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/RULES.md b/RULES.md
@@ -100,6 +100,7 @@ Each Notice is associated with a severity: `INFO`, `WARNING`, `ERROR`.
 | [`leading_or_trailing_whitespaces`](#leading_or_trailing_whitespaces)                         | The value in CSV file has leading or trailing whitespaces.                                                                                                    |
 | [`missing_feed_info_date`](#missing_feed_info_date)                                           | `feed_end_date` should be provided if `feed_start_date` is provided. `feed_start_date` should be provided if `feed_end_date` is provided.                     |
 | [`missing_recommended_file`](#missing_recommended_file)                                       | A recommended file is missing.                     |
+| [`missing_recommended_field`](#missing_recommended_field)                                        | A recommended field is missing.                     |
 | [`missing_timepoint_column`](#missing_timepoint_column)                                       | `timepoint` column is missing for a dataset.                                                                                                                  |
 | [`missing_timepoint_value`](#missing_timepoint_value)                                         | `stop_times.timepoint` value is missing for a record.                                                                                                         |
 | [`more_than_one_entity`](#more_than_one_entity)                                               | More than one row in CSV.                                                                                                                                     |
@@ -1715,6 +1716,26 @@ A recommended file is missing.
 
 </details>
 
+### missing_recommended_field
+
+The given field has no value in some input row, even though values are recommended.
+
+#### References
+* [feed_info.txt bets practices](https://github.com/MobilityData/GTFS_Schedule_Best-Practices/blob/master/en/best-practices.md#feed_infotxt)
+<details>
+
+#### Notice fields description
+| Field name   	| Description                    	| Type   	|
+|--------------	|--------------------------------	|--------	|
+| `filename`   	| The name of the faulty file.   	| String 	|
+| `csvRowNumber`| The row of the faulty record.  	| Long   	|
+| `fieldName`  	| The name of the missing field. 	| String 	|
+
+#### Affected files
+* [`feed_info.txt`](http://gtfs.org/reference/static#feed_infotxt)
+
+</details>
+
 ### missing_timepoint_column
 
 The `timepoint` column should be provided.

diff --git a/main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedInfoSchema.java b/main/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedInfoSchema.java
@@ -40,16 +40,21 @@ public interface GtfsFeedInfoSchema extends GtfsEntity {
 
   Locale defaultLang();
 
+  @Recommended
   @EndRange(field = "feed_end_date", allowEqual = true)
   GtfsDate feedStartDate();
 
+  @Recommended
   GtfsDate feedEndDate();
 
+  @Recommended
   String feedVersion();
 
+  @Recommended
   @FieldType(FieldTypeEnum.EMAIL)
   String feedContactEmail();
 
+  @Recommended
   @FieldType(FieldTypeEnum.URL)
   String feedContactUrl();
 }