-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updates acceptance tests to use the Mobility Database Catalogs #1204
feat: Updates acceptance tests to use the Mobility Database Catalogs #1204
Conversation
Meta comment: I don't think I'd ever looked too closely at the |
We have 1332 GTFS Schedule sources in the Mobility Database catalogs. Previously, 1117 on the Wikibase instance (more actually, but we noticed that many were duplicates). So we will run acceptance tests on 215 additional sources. A lot of downloads every time a PR is updated, indeed! It is possible to skip the acceptance tests by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - assuming the acceptance test runs to completion, this looks ready to go.
Thank you for this contribution! 🍰✨🦄 Information about source corruption0 out of 1334 sources are corrupted. Acceptance test detailsThe changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase. |
Summary:
Closes #1143
This PR update the acceptance tests so that they use the Mobility Database Catalogs instead of the outdated Wikibase instance.
Expected behavior:
Acceptance tests should be run on the sources included in the Mobility Database Catalogs. Since the catalogs can be downloaded as a CSV file, acceptance tests should be much faster when fetching the URLs (no more waiting on the Wikibase API!). Also, the data is in greater quantity and more accurate.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anythingInclude screenshot(s) showing how this pull request works and fixes the issue(s)