-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor the output comparator to consider dropped errors #1238
feat: Refactor the output comparator to consider dropped errors #1238
Conversation
… a general refactoring of the report generation logic. Includes pulling more logic out of Main and adding specific model classes for JSON serialization.
@maximearmstrong this is mostly ready for review and I'd love your feedback if you have cycles. It isn't fully ready to review/commit because I haven't updated the |
I agree. I think it would also be better from a design standpoint if the output comparator took on that responsibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few comments, but overall it's great! The new design brings a lot of clarity to the code. Thanks a lot @bdferris-v2!
output-comparator/src/main/java/org/mobilitydata/gtfsvalidator/outputcomparator/cli/Main.java
Show resolved
Hide resolved
...c/main/java/org/mobilitydata/gtfsvalidator/outputcomparator/model/report/AffectedSource.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/mobilitydata/gtfsvalidator/outputcomparator/io/ChangedNoticesCollector.java
Show resolved
Hide resolved
I've updated the comment generation code, as discussed. This is ready for final review. |
Thanks for working on this @bdferris-v2 ! What is going to be the schema of the new report with these changes? |
I've approved the PR. Thanks @bdferris-v2!
@isabelle-dr do we need clarity on these items before merging? |
Thanks Maxime, I think it is in the scope of this PR to update ACCEPTANCE_TESTS.md with the changes (addition of dropped errors, report schema change). |
@isabelle-dr I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks @bdferris-v2
Also includes a general refactoring of the report generation logic:
As discussed in #1232.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything