feat: changes + added documentation to features #1844
Conversation
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 6258fab 📊 Notices ComparisonNew Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
main/src/main/java/org/mobilitydata/gtfsvalidator/report/model/FeedMetadata.java
Outdated
Show resolved
Hide resolved
|
@cka-y Looks great! Super minor feedback: Capitalize "In-Station Traversal Time" @tzujenchanmbd @Sergiodero Do you know of specific feeds in the production list that have Predefined Routes with Deviation or Fixed Stops Demand Responsive Service to test with? I'm having some trouble identifying them. |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit f6086bf 📊 Notices ComparisonNew Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
✅ done @emmambd |
|
@emmambd |
|
@tzujenchanmbd It looks like the Predefined Routes doesn't trigger for the feed you provided. I think it's because the logic for it from #1776 was:
It looks like it's either location_id or stop_id from the data. Should the rule instead be: Two trips: At least one trip in stop_times references location_id AND one trip in stop_times references stop_id, arrival_time and departure_time |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit a489275 📊 Notices ComparisonNew Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1575 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1575 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
@emmambd The rule should still check within 1 trip instead of 2. It seems the trip |
|
I'll add a new issue for the problem with Predefined Routes. @cka-y, last comment
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 5eed6b3 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
Summary:
Expected Behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything