Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexibility to build Debug components #136

Merged
merged 13 commits into from
Jun 15, 2024

Conversation

Holt59
Copy link
Member

@Holt59 Holt59 commented Jun 9, 2024

The goal of this PR is to:

  • Make it easier to build USVFS Release tests (ReleaseTest configuration). Currently, it's kind of annoying because USVFS is build with /MT but GoogleTest with /MD (due to gtest_force_shared_crt in mob). Trying to build the test configuration of USVFS with /MD instead of /MT then throws issue with some missing boost components, especially for x86. The fix for this is to move the ReleaseTest configuration of USVFS to /MD (the Release configuration will be untouched) and to add the missing boost components.
  • Make it easier to build USVFS and other libraries with tests in Debug mode. Currently it is not possible (without rebuilding googletest manually) because the Debug libraries of GoogleTest are not built. The fix for this is to build the Debug and Release configuration for GoogleTest. For USVFS, direct path to the appropriate build folder are added. Other components will still use GTEST_ROOT.
  • Make it possible to build components in Debug/Release mode through mob (instead of RelWithDebInfo).

The following components support debug mode:

  • libbsarch - Since libbsarch is not built by mob, this only changes the archive that is downloaded.
  • python - This build Python in debug mode. Some changes have been made to plugin_python to match the changes.
  • pyqt - This build PyQt in debug mode, but requires Python in debug mode.

PyQt debug build is a mess, so there are many "workaround", but I made sure to not modify the release path.

@Holt59 Holt59 changed the title More flexibility to build Debug components WIP: More flexibility to build Debug components Jun 9, 2024
@Holt59 Holt59 changed the title WIP: More flexibility to build Debug components More flexibility to build Debug components Jun 15, 2024
@Holt59 Holt59 merged commit ecd210d into master Jun 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant