Add mutagen support #71
Conversation
arendarenko
force-pushed
the
add-mutagen-support
branch
3 times, most recently
from
e91d344
to
0320798
Compare
- add mutagen tasks lib - update commands in order to work with mutagen - update configuration in order to work with mutagen - remove unnecessary volume declaration in docker-compose for mac
arendarenko
force-pushed
the
add-mutagen-support
branch
from
0320798
to
c3405a0
Compare
|
this need to be added:
|
| @@ -4,11 +4,11 @@ services: | |||
| phpfpm: | |||
| volumes: &appvolumes-mac | |||
| - workspace:/var/www/html | |||
| - ./app:/var/www/html/app:delegated | |||
There was a problem hiding this comment.
Hi! @arendarenko this change is probably going to break the mac setup if you don't use mutagen. Maybe I'm not uderstanding it in the right way, could you explain me this change? Thank you!
There was a problem hiding this comment.
Maybe it's better to fully switch to mutagen instead or having an option?
There was a problem hiding this comment.
I dont know if it's a good option because you are making this project dependant on mutagen, and we're forcing ppl to install mutagen in order to be able to use this tool!
Could be great making it optional!
There was a problem hiding this comment.
@danielozano i think it’s better to add one more tool for Mac OS in order to get much better experience.
|
@ihor-sviziev I agree with @danielozano . The purpose of this tool was always to keep it as simple as possible without needing to install anything but docker. I do not doubt that mutagen might improve it but in that case it should be optional. You could create a pull request to update the docs instead. Add a new section with the couple of steps needed for mutagen for those who want to use it. I think that would be the best for now. What do you think? |
|
I checked the PR again and noticed that a lot of changes are needed, so this could be difficult to explain in the docs. I noticed that you use the param USE_MUTAGEN which is great. To approve this PR, you should update the setup command to give the user the option to use mutagen or not during the setup. If yes is selected, then the parameter should be set automatically to 1 and the docker-compose.yml for mac can be changed accordingly. Do you know how to implement that? |
|
Hi @ihor-sviziev, @danielozano, @jalogut. Thanks for your comments. Tbh I don't see any reason to use unison any further since mutagen is working in background and you don't need to enable/disable sync manually anymore. But I'm agree with @jalogut that for backward compatibility sake we need to have both: unison and mutagen tools support for mac, so I will update this PR and let you know. |
|
Yes, for that I think the simplest would be to add a check on the |
|
How about this https://docs.docker.com/docker-for-mac/mutagen-caching/? I have already tried edge and it works fine. |
Description
These changes is related to #64
Working with dockergento on Mac is really challenging because you always need to run sync manually when modifying something on the host.
Using mutagen.io tool developers who use Mac can eliminate this step and be more focused on coding.
This PR adds mutagen support without breaking "unison-way" sync.
How to test
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"brew install havoc-io/mutagen/mutagenUSE_MUTAGEN_SYNC="1"to properties fileOther notes
mutagen sync list