Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long arguments #10

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Long arguments #10

merged 2 commits into from
Sep 26, 2018

Conversation

Earthcomputer
Copy link
Contributor

Adds a long argument type to be along with the other default primitive argument types (integer, double, etc.). I have needed this a couple of times already in a couple of Minecraft mods and thought this ought to go in brigadier itself rather than create it myself for every mod I make.

@msftclas
Copy link

msftclas commented Sep 26, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@grum grum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second that.

@Dinnerbone Dinnerbone merged commit b10b447 into Mojang:master Sep 26, 2018
@Earthcomputer Earthcomputer deleted the long_arg branch September 27, 2018 19:41
A248 pushed a commit to SolarMC-Dev/brigadier that referenced this pull request Jun 18, 2021
Revert permission-related suggestion provider changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants