Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer pint version for Python >=3.9 #335

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Use newer pint version for Python >=3.9 #335

merged 2 commits into from
Feb 29, 2024

Conversation

TyBalduf
Copy link
Contributor

Pint >= 0.10 fails for newer numpy versions, in particular >= 1.25.

This change bumps up the version requirements for Pint in cases where we are using newer numpy.

Description

See #334

Changelog description

Use newer pint version for Python >=3.9

Status

  • Code base linted
  • Ready to go

Pint  >= 0.10 fails for newer numpy versions, in particular >= 1.25.

This change bumps up the version requirements for Pint in cases where we are using newer numpy.
Copy link
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #335 (25d332a) into master (e942b81) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

pyproject.toml Outdated Show resolved Hide resolved
@loriab loriab merged commit 8e5a8cf into MolSSI:master Feb 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants