Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need graphviz #342

Merged
merged 5 commits into from
Sep 18, 2024
Merged

need graphviz #342

merged 5 commits into from
Sep 18, 2024

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Jul 24, 2024

Description

  • I strongly suspect this'll fix Class inheritance diagram not rendering #333 which wasn't working b/c dot not present b/c it can't be installed by pypi. (Can be installed thru conda.) Fortunately there's a GHA action to the rescue.
  • Missing class docstrings were generating ERROR: Content block expected for the "raw" directive; none found.
  • the unescaped qc_ were being interpreted as sphinx links
  • I don't think there's harm in importing nglview with forgiveness. It's the only way the docs build can recognize the forward reference.
  • there's still many (15) duplicate object description warnings, but I'll defer those

Changelog description

Status

  • Code base linted
  • Ready to go

@loriab loriab merged commit 248d988 into MolSSI:master Sep 18, 2024
17 checks passed
@loriab loriab deleted the fixdocsdiagrams branch September 18, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class inheritance diagram not rendering
2 participants