add hashes and rearrange mult handling #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is preparatory to #318.
Molecule(..., validate=False)
. I believe this is a universally good check, but it is a new restriction. Any weird positron, fractional electron, etc. reason to not catch less-than-one mult?validate_and_fill_chgmult
testing) to molecules, so we'll know if code starts changing the hash and thereby disrupting the QCA server.qcel.molparse
has a different error message for less-than-onefragment_multiplicities
you try to put through it.qcel.molparse
is accessed wheneverMolecule(...)
orMolecule(..., validate=True)
is called.qcel.molparse
newly allows floats that are ints (e.g.,1.0
) for multiplicity. previously it would raise an error about not being an int.qcel.molparse
newly has a dedicated error for any less-than-onemolecular_multiplicity
you try to put through it. Previously it raised the usual "Inconsistent" error.Changelog description
Status