Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csse pyd2 model convert classes #352

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Sep 24, 2024

Description

currently atop #349

  • main Input/Result classes and FailedOperation gained a convert_v(<ver>) function to transform to other version. transformation trivial at this point b/c this is pydantic's purpose, but functions will differentiate at the rearrangement milestone. Needed to actually validate schema_version field so it would overwrite at conversion.
  • added model_dump, model_dump_json, copy_model to v1 so easier to write code that can take both model types. Levi had done the reverse and added dict, json, copy to v2, but I'm thinking this is the better way. Haven't removed Levi's fns.

Changelog description

Status

  • Code base linted
  • Ready to go

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 32.80632% with 170 lines in your changes missing coverage. Please review.

Project coverage is 86.11%. Comparing base (a1f7dcc) to head (9a82402).
Report is 1 commits behind head on next2024.

Additional details and impacted files

@loriab loriab changed the title Csse pyd2 converterclasses Csse pyd2 model convert classes Oct 1, 2024
@loriab
Copy link
Collaborator Author

loriab commented Oct 3, 2024

Requesting review @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131

@loriab loriab merged commit 4f8a691 into MolSSI:next2024 Oct 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants