Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: 0.12.1 void order status check #162

Conversation

eoin-betdex
Copy link
Contributor

@eoin-betdex eoin-betdex commented Dec 6, 2023

When orders are cancelled in certain cases and are kept open with their status updated to Cancelled the market settled_account_count is decremented. If that market is subsequently voided, then void_order incorrectly also decrements settled_account_count for those orders. This can result in the settled_account_count prematurely reaching 0 and preventing market voiding from completing completely.

This fix corrects void_order, preventing Cancelled orders from affecting the market's settled_account_count during voiding.

This issue was introduced in 0.12.0. Correct handling of Cancelled orders was added to order settlement, but was missed from order voiding.

Screenshot 2023-12-06 at 10 16 39 Screenshot 2023-12-06 at 10 06 51 Screenshot 2023-12-06 at 10 14 32

@eoin-betdex eoin-betdex merged commit 7d70c2b into MonacoProtocol:main Dec 6, 2023
@eoin-betdex eoin-betdex deleted the hotfix/0.12.1-void-order-status-check branch December 6, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants