hotfix: 0.12.1 void order status check #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When orders are cancelled in certain cases and are kept open with their status updated to
Cancelled
the marketsettled_account_count
is decremented. If that market is subsequently voided, thenvoid_order
incorrectly also decrementssettled_account_count
for those orders. This can result in thesettled_account_count
prematurely reaching0
and preventing market voiding from completing completely.This fix corrects
void_order
, preventingCancelled
orders from affecting the market'ssettled_account_count
during voiding.This issue was introduced in 0.12.0. Correct handling of
Cancelled
orders was added to order settlement, but was missed from order voiding.