Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A potential bug in Audio/Xact/Cue.cs #5493

Closed
valhristov opened this issue Feb 22, 2017 · 2 comments
Closed

A potential bug in Audio/Xact/Cue.cs #5493

valhristov opened this issue Feb 22, 2017 · 2 comments
Labels
Help Wanted

Comments

@valhristov
Copy link

I found a potential bug with the SonarC# plugin for SonarQube - on the following line _curSound could be null (because you check for null on the line before that):
https://github.com/MonoGame/MonoGame/blob/develop/MonoGame.Framework/Audio/Xact/Cue.cs#L260

All the best,
Valeri
@tomspilman
Copy link
Member

We noticed this the other day too... it is indeed a bug.

@tomspilman tomspilman assigned tomspilman and unassigned tomspilman Feb 23, 2017
@06needhamt 06needhamt mentioned this issue Feb 27, 2017
Closed
@tomspilman
Copy link
Member

Fixed in #5709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomspilman @valhristov