Removed Windows 8.1 and Windows Phone 8.1 support #5809
Conversation
|
This is really fun to do :D |
@tomspilman The NAnt script on the build bot should be updated to not build (or do anything else) with the Win8/WP projects. |
|
I guess open issues related to WP/Win 8/8.1 can be closed now with a comment saying they are not fixed, but platform support was dropped. Would be nice if someone with more knowledge of the Windows ecosystem can confirm that these are no longer relevant. Maybe @DDReaper or @nkast? Issues related to Windows Phone 8/8.1#1051 Issues related to Windows 8/8.1#933 *: Possibly still relevant for UWP. Most of these are touch related. Possibly some of these are fixed by #5520 |
|
You beat me to it @Jjagg I'll see if I can start going through those issues tonight to check there is anything we need to be concerned about. |
|
Most of those issues are over a year (most 2 years) old, so I think it's fair to close them as MG has moved on a lot since then. @tomspilman / @KonajuGames , if you want to give me issue admin rights on Github, I'll go through and clean them up. |
Actually you can't get only issue closing rights on GitHub, I know, I've asked a similar question several months ago :( |
|
Will be merged after 3.7 is out. |
Sorry to be brash @cra0zy but why? After every release recently, MonoGame get's hit with crazy errors on some platforms and there is absolutely no reason to continue to support those platforms for 3.7. Even MS is removing it now from their other OS releases. like other platforms, if they still want Win 8.1 / WP8.1 support then users can stay on 3.6. I personally see no value in keeping it on for another release. UWP is still broken from 3.6 with hints at a point release and with Dream Build Play hitting our doors, users are still struggling getting new projects running on 2017, all fixed in source and dev releases (which is where I generally send them) /Rant |
Wrong person there buddy :) |
|
Darn it, sorry @cra0zy. Same point / rant to you @KonajuGames Why after 3.7? This makes no sense. |
|
@Jjagg do you have time to rebase this? |
|
Yeah, will do |
|
@Jjagg you still rebasing this PR, or if you've run out of time, do you want me to just resubmit it? |
|
It's rebased, but the build fails because of |
That is set on the build server. For now leave the old I will follow up with a PRs fixing this once and for all. |
|
Go on @Jjagg , make my B'Day and try and get this read to merge today. |
|
@Jjagg @DDReaper - Looks like we broke NuGet.... https://github.com/MonoGame/MonoGame/blob/develop/NuGetPackages/MonoGame.Framework.DX.nuspec This still references the Windows 8/8.1 stuff. Can someone submit a PR to fix this? |
|
If you can get that SharpDX PR merged, I'll get that sorted now |
|
PR #5951 submitted to fix NuGet's |
tomspilman
changed the title
* Remove Windows 8.1 and Windows Phone 8.1 support * Remove Win8.1 and WP preprocessor directives * Replace WINRT with WINDOWS_UAP and remove the define * Re-add removed method stub needed for compilation * Remove Windows 8 Store from docs * Remove build VS2012 templates in NAnt script * Remove WP8.1 in Windows nsi installer * Remove some leftover files * Re-add build targets * Remove duplicate file include * Re-add SignedInGamer for UWP
As per #5807 :)
I checked installers, NuGets, templates and Protobuild files and removed files that are not used by other platforms. I still need to check preprocessor directives. Anything else?