-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to SharpDX 4.0.1 #5949
Upgrade to SharpDX 4.0.1 #5949
Conversation
Woot, that was quick @Jjagg |
I don't really remember, but all porting issues were resolved with the 3.x upgrade. EDIT: It seems the build bot won't run tests (I guess because no code changed), but everything passes locally :) |
@Jjagg - Doesn't this depend on MonoGame/MonoGame.Dependencies#111 ? |
Yes, it does. Sorry, forgot to mention that 😅 |
So is this good to go @Jjagg assuming the other PR is merged as well. Or is it worth closing the other PR and bringing the changes in to this PR? |
Dependencies PR is merged. |
@Jjagg - Go ahead and update the dependencies now that it is merged. |
Woot, this is certainly something to shout about. |
This will just need merging now once #5951 is merged. TO keep the SharpDX upgrade aligned |
This seems good to merge now... thanks @Jjagg ! |
* Upgrade SharpDX dependencies * Upgrade references
Not much to do here apart from upgrading the references and dependencies. The dll's are the ones that target .NET Standard 1.1 so we can use them for both DX and UWP. I did need the .NET 4.5 dll for MediaFoundation because
CreateSampleGrabberSinkActivate
is only available on Desktop and thus not in the .NET Standard assembly.